-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #784 -- Added migrations autodetected by Django 4.0 #785
Fixed #784 -- Added migrations autodetected by Django 4.0 #785
Conversation
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 92.46% 92.74% +0.28%
==========================================
Files 9 9
Lines 703 703
Branches 136 136
==========================================
+ Hits 650 652 +2
+ Misses 35 34 -1
+ Partials 18 17 -1
Continue to review full report at Codecov.
|
Will try to figure out the consequences of this, for libraries we gotta be a bit careful because people are rarely v checking migrations provided by libraries... |
will need a new release as well |
If it helps, Django's release notes mentions that the operation are "no-op". Also, the test I added in the PR should be a strong guarantee that the state of migrations is clean no matter the Django version (I assume tests are run with all supported Django versions). Let me know if I can be of more help, and thanks everyone for the fast response 👍🏻 |
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
merging this for now. any follow up improvements are welcome |
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
Happy to report that this was the final blocker in django-taggit towards Django 4.0 support in Wagtail, and with this fix merged we now have Wagtail successfully running under Django 4.0 (wagtail/wagtail#7829). Please consider this a vote of confidence and a nudge for making a new django-taggit release :-) |
No description provided.