Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #784 -- Added migrations autodetected by Django 4.0 #785

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

bmispelon
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #785 (471914e) into master (5556944) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   92.46%   92.74%   +0.28%     
==========================================
  Files           9        9              
  Lines         703      703              
  Branches      136      136              
==========================================
+ Hits          650      652       +2     
+ Misses         35       34       -1     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
taggit/managers.py 95.93% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5556944...471914e. Read the comment docs.

@auvipy auvipy self-requested a review January 6, 2022 12:48
@auvipy auvipy requested a review from rtpg January 6, 2022 18:00
@rtpg
Copy link
Contributor

rtpg commented Jan 6, 2022

Will try to figure out the consequences of this, for libraries we gotta be a bit careful because people are rarely v checking migrations provided by libraries...

@auvipy
Copy link
Contributor

auvipy commented Jan 7, 2022

will need a new release as well

@bmispelon
Copy link
Contributor Author

Will try to figure out the consequences of this, for libraries we gotta be a bit careful because people are rarely v checking migrations provided by libraries...

If it helps, Django's release notes mentions that the operation are "no-op".

Also, the test I added in the PR should be a strong guarantee that the state of migrations is clean no matter the Django version (I assume tests are run with all supported Django versions).

Let me know if I can be of more help, and thanks everyone for the fast response 👍🏻

gasman added a commit to gasman/wagtail that referenced this pull request Jan 7, 2022
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
gasman added a commit to gasman/wagtail that referenced this pull request Jan 7, 2022
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
@auvipy auvipy merged commit 9d9ca4b into jazzband:master Jan 7, 2022
@auvipy
Copy link
Contributor

auvipy commented Jan 7, 2022

merging this for now. any follow up improvements are welcome

gasman added a commit to gasman/wagtail that referenced this pull request Jan 7, 2022
To be reverted when django-taggit releases a Django 4.0 compatible version incorporating jazzband/django-taggit#785
@gasman
Copy link
Contributor

gasman commented Jan 13, 2022

Happy to report that this was the final blocker in django-taggit towards Django 4.0 support in Wagtail, and with this fix merged we now have Wagtail successfully running under Django 4.0 (wagtail/wagtail#7829). Please consider this a vote of confidence and a nudge for making a new django-taggit release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants