Fix Django 4 compatibility issues #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a shim around `get_extra_restriction` so that it works in versions of Django >=4 and <4 - fixes jazzband#776
auvipy
reviewed
Dec 15, 2021
taggit/managers.py
Outdated
| # this is required to handle a change in Django 4.0 | ||
| # https://docs.djangoproject.com/en/4.0/releases/4.0/#miscellaneous | ||
| # the signature of the (private) funtion was changed | ||
| if django.VERSION > (3, 8): |
There was a problem hiding this comment.
Ah, woops, should be (3, 2).
There was a problem hiding this comment.
Fixed this, I flipped it round to do < (4, 0) instead.
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 92.39% 92.46% +0.06%
==========================================
Files 9 9
Lines 697 703 +6
Branches 135 136 +1
==========================================
+ Hits 644 650 +6
Misses 35 35
Partials 18 18
Continue to review full report at Codecov.
|
|
Thanks @monty5811 👍
|
|
Looks good to me too, once we fix up the above comments! Thank you for sending this in 👍 |
auvipy
approved these changes
Dec 16, 2021
|
Hi, when can we expect a new version including this fix to land in pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
where_classargument to the privateget_extra_restriction()was changed in Django 4.0.A simple change is to remove the
where_classargument here. But that breaks taggit on lower versions of django.To fix this, I added a shim that checks the django version and uses the correct function.
I have no idea if this is the best way to fix this, but the tests pass 🤷♂️
Relevant issue: #776
Note that this PR has a commit from #777 too.