GH-512: allow foreign key to reference self using self str #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nKey to self
Description
This PR adds tests for models with foreign keys to themselves. It also adds functionality (which was accidentally removed in #462) that allows developers to use a
'self'
string when creating a self-referential foreign key.Related Issue
Fixes #512
Motivation and Context
Users that use the string
'self'
when using self-referential ForeignKeys will likely see migrations when updating from django-simple-history 2.5.1 to 2.6.0. Those migrations will point the historical foreign keys to the historical models rather than the base models. This can be fixed locally by using the model's name rather than'self'
, as shown below:How Has This Been Tested?
Added 2 tests:
'self'
results in the correct foreign key on the historical model (this is fixed by this PR)Screenshots (if appropriate):
Types of changes
Checklist:
make format
command to format my codeAUTHORS.rst
CHANGES.rst