Fix sentinel mode read-write separation #749
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I attempted to set up read-write separation in Sentinel mode by configuring redis://redis-master/db?is_master=0, I noticed that both read and write requests were still being directed to the master node, without any separation. After reviewing and debugging the source code, I found that the issue was due to redis-py being unable to correctly parse the is_master parameter, and there was also an error in how the project handled is_master. The pool.is_master was only set to False after retrieving the redis.sentinel.SentinelConnectionPool object from redis-py, which resulted in the system supposedly using the slave node, but actually using the master node.