Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorted set functions to RedisCache #673

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nazhixx
Copy link

@Nazhixx Nazhixx commented Jul 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #673 (d303159) into master (0756a8b) will increase coverage by 23.6%.
The diff coverage is 37.5%.

@@            Coverage Diff            @@
##           master    #673      +/-   ##
=========================================
+ Coverage    60.0%   83.6%   +23.6%     
=========================================
  Files          39      21      -18     
  Lines        2534    1181    -1353     
  Branches       69       0      -69     
=========================================
- Hits         1520     987     -533     
+ Misses       1001     194     -807     
+ Partials       13       0      -13     
Flag Coverage Δ
mypy ?
tests 83.6% <37.5%> (-5.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
django_redis/client/default.py 75.2% <20.0%> (-15.2%) ⬇️
django_redis/cache.py 90.3% <66.7%> (-7.4%) ⬇️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice effort but I see no tests nor changelog and I am afraid that without those this PR can't be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants