Fix flake8 and tox dependencies #198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 64.64% 63.81% -0.84%
==========================================
Files 17 17
Lines 478 467 -11
==========================================
- Hits 309 298 -11
Misses 169 169
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I am converting this to draft since |
|
OK, this is ready for review. Hoever, I'm unsure why the test coverage is dropping since most changes are lint. |
| args: [--max-line-length=88] | ||
| - repo: https://github.com/asottile/reorder_python_imports |
There was a problem hiding this comment.
Removing this since it is already handled by isort
There was a problem hiding this comment.
This is not entirely true - isort does not seperate imports into multiple lines: https://github.com/asottile/reorder_python_imports#why-this-style
I vote we replace isort with reorder_pyton_imports.
| @@ -52,12 +50,4 @@ repos: | |||
| - repo: https://github.com/asottile/yesqa | |||
| rev: v1.4.0 | |||
| hooks: | |||
| - id: yesqa | |||
| - repo: https://github.com/asottile/add-trailing-comma | |||
There was a problem hiding this comment.
Removing this since it is handled by black.
There was a problem hiding this comment.
Not entirely. Black does not add trailing commas when the arguments include *, *args or **kwargs.
I vote we keep add-trailing-comma
There was a problem hiding this comment.
Ok, we can add it in a follow-up PR
|
@jezdez, could you take a look at this PR? |
Closes #196
Closes #197
Changes
flake8andtoxReferences