refactor(models): use get_current_site from django shortcuts #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmikolay
added a commit
to mattmikolay/django-invitations
that referenced
this pull request
Jun 15, 2023
From what I can tell, Django's sites framework is no longer required now that jazzband#150 has been merged. So, the references to the sites framework in the installation docs can be removed. It's worth noting that django-allauth still requires the sites framework, but django-allauth's own docs already mention this.
valberg
pushed a commit
that referenced
this pull request
Nov 22, 2023
From what I can tell, Django's sites framework is no longer required now that #150 has been merged. So, the references to the sites framework in the installation docs can be removed. It's worth noting that django-allauth still requires the sites framework, but django-allauth's own docs already mention this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
get_current_sitefromdjango.contrib.sites.shortcutsinstead of hard coding with theSiteobject for better compatibility with multi sites and non-multi sites django instalations. As said in the docs of the functiondef get_current_site(request):