Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions configuration #419

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Fix GitHub Actions configuration #419

merged 2 commits into from
Jan 9, 2022

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Jan 9, 2022

Bug Fix

Description

The GitHub Actions tox configuration was misconfigured such that no unit tests were actually running.

This was due in part to non-standard tox configuration conventions py3.6 vs py36. This PR uses the standard Python versioning that is available by default in tox.

Regression in

Also remove deprecated import that caused failure under Python 3.10

Why should this be added

Currently no unit tests are running on CI

@johnthagen
Copy link
Contributor Author

This is a legitimate 3.10 testing failure:

    File "/home/runner/work/django-dbbackup/django-dbbackup/dbbackup/tests/testapp/urls.py", line 8, in <module>
      from django.conf.urls import include, url
  ImportError: cannot import name 'url' from 'django.conf.urls' (/home/runner/work/django-dbbackup/django-dbbackup/.tox/py310-django40/lib/python3.10/site-packages/django/conf/urls/__init__.py)

@Archmonger Archmonger merged commit 9aab6c9 into jazzband:master Jan 9, 2022
@Archmonger
Copy link
Contributor

@johnthagen As quick note, all Jazzband members have the ability to merge PRs.

Being a project lead only provides the ability to create releases on PyPI.

Also, jezdez has added me as a project lead according to https://jazzband.co/projects/django-dbbackup

@johnthagen johnthagen deleted the fix-github-actions branch January 9, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants