-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-gnupg version increase breaks unencrypt_file function #460
Comments
If this gets accepted, I'd like to take a stab at fixing it. Just want some input on whether it is better to compare versions or pin the python-gnupg version in the requirements/tests.txt file. Compare versions pseudo-code: if parse_version(gnupg.version) >= parse_version("5.0.0"): |
In general, it's best to practice pin the minimum version and keep the max unpinned. I'd be okay with reviewing a PR that supports |
I'll submit a PR to address this later today, thanks for the input. |
Bug Report
Describe the bug
Latest version of python-gnupg on PyPi is 0.5.0. The file argument for gnupg.GPG().decrypt_file has changed from "file" to "fileobj_or_path". This is causing tests to fail with error "TypeError: GPG.decrypt_file() got an unexpected keyword argument 'file'".
decrypt_file can be found here.
Failing tests:
If tests are failing, decryption of the backups are likely failing to for newer installs.
To Reproduce
Alternatively, in a django project
Expected behavior
Tests pass, backups are decrypted
Versions
Django-dbbackup
External tools
The text was updated successfully, but these errors were encountered: