Fix serialize __proxy__ objects before logging #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 95.21% 95.25% +0.03%
==========================================
Files 31 31
Lines 1025 1033 +8
==========================================
+ Hits 976 984 +8
Misses 49 49 ☔ View full report in Codecov by Sentry. |
|
Thanks @Nathan-Cohen for the PR. |
Nathan-Cohen
force-pushed
the
serializer-proxy-objects
branch
2 times, most recently
from
f80223d
to
408b649
Compare
|
@hramezani it's done, I've added the tests and the changelog |
hramezani
reviewed
Apr 8, 2024
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ | |||
| - feat: If any receiver returns False, no logging will be made. This can be useful if logging should be conditionally enabled / disabled ([#590](https://github.com/jazzband/django-auditlog/pull/590)) | |||
| - Django: Confirm Django 5.0 support ([#598](https://github.com/jazzband/django-auditlog/pull/598)) | |||
| - Django: Drop Django 4.1 support ([#598](https://github.com/jazzband/django-auditlog/pull/598)) | |||
| - Fixed logging problem related to django translation before logging ([#624](https://github.com/jazzband/django-auditlog/pull/624)) | |||
There was a problem hiding this comment.
please move it up. this shouldn't be under 3.0.0-beta.4 that is already released
|
Thanks @Nathan-Cohen. just a small comment and then we are ready to merge |
Nathan-Cohen
force-pushed
the
serializer-proxy-objects
branch
from
915769c
to
39bd421
Compare
for more information, see https://pre-commit.ci
hramezani
reviewed
Apr 8, 2024
hramezani
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I created this Pull Request in response to the user's request regarding the logging issue related to django translation before logging (#606). I've encountered the problem myself and I think the easiest way is to make a correction in the library.
Example :
Error encountered : TypeError:
Object of type __proxy__ is not JSON serializableI think this is more of a bug than an improvement.