-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correlation ID - Part 1 #481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 92.83% 93.24% +0.41%
==========================================
Files 27 29 +2
Lines 795 859 +64
==========================================
+ Hits 738 801 +63
- Misses 57 58 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@hramezani updated. |
Thanks @aqeelat for the update. Please add documentation for the new settings and also add tests for checking the saved cid in the model. |
…ere's no cid test: improved test structure
chore: `Union[None, str]` -> `Optional[str]`
@hramezani done |
Thanks @aqeelat for updating the patch. Please also add test to proved saved cid value in model |
Co-authored-by: Hasan Ramezani <[email protected]>
Co-authored-by: Hasan Ramezani <[email protected]>
I added the test already. It should be in the same middleware test. I compared the value in the history with the expected value. |
I think everything is done. you just need to update the comment in |
fix: checked for the header in META
@hramezani all is done now. LMK if you need anything else. |
feat: Added support for storing correlation ids passed to a custom header