added fix for OneToOneRel error happening in case of Polymorphic model #429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 92.24% 92.28% +0.04%
==========================================
Files 24 24
Lines 709 726 +17
==========================================
+ Hits 654 670 +16
- Misses 55 56 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @rahulpr27git for this patch 👍 |
…has no attribute 'default'
for more information, see https://pre-commit.ci
tox.ini
Outdated
| @@ -21,6 +21,7 @@ deps = | |||
| codecov | |||
| freezegun | |||
| psycopg2-binary==2.8.6 | |||
| django-polymorphic | |||
There was a problem hiding this comment.
Do we need django-polymorphic for testing? isn't it possible to add test without this?
There was a problem hiding this comment.
yes. it's happening with a Polymorphic model so need this dependency else i wont be able to reproduce.
There was a problem hiding this comment.
I would take a look. it may be possible to reproduce the problem without Polymorphic. Otherwise, we can accept it.
There was a problem hiding this comment.
Ok. thanks.
this is currently became a major blocker for my project.
Hopefully we can resolve this one as soon as possible.
There was a problem hiding this comment.
@hramezani updated the test
There was a problem hiding this comment.
Thanks @rahulpr27git.
Seems hard to reproduce the problem without Polymorphic. I would suggest just keeping the change and reverting all the changes related to the test. we will accept this change without tests. Because the fix itself is clear and I don't want to include another project just for one single test.
There was a problem hiding this comment.
@hramezani please check again.
jazzband#429) (munged a bit to work with our old version of auditlog)
jazzband#429) (modified for django-auditlog v0.5.3)
No description provided.