Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mask_fields argument in register #310

Merged
merged 10 commits into from
Mar 10, 2022

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented Jul 2, 2021

Add support for mask_fields #300 to mask sensitive info in the logs

@aminalaee aminalaee changed the title add-masked-fields-option add-mask-fields-option Jul 5, 2021
@Linkid Linkid linked an issue Jan 12, 2022 that may be closed by this pull request
auditlog_tests/tests.py Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @aminalaee for this patch 👍
I've left some small comments.
Please address them and rebase your patch.

auditlog/diff.py Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
@aminalaee
Copy link
Contributor Author

@hramezani
Thanks for the review, it should be ok now.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #310 (eab48ef) into master (dad4fb8) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   82.57%   82.81%   +0.23%     
==========================================
  Files          20       20              
  Lines         505      512       +7     
==========================================
+ Hits          417      424       +7     
  Misses         88       88              
Impacted Files Coverage Δ
auditlog/diff.py 88.40% <100.00%> (+0.90%) ⬆️
auditlog/registry.py 91.37% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad4fb8...eab48ef. Read the comment docs.

@hramezani
Copy link
Member

Thanks @aminalaee,
The last thing, Please add a changelog entry.

@aminalaee aminalaee changed the title add-mask-fields-option Add mask_fields argument in register Mar 10, 2022
@hramezani hramezani merged commit bb5f995 into jazzband:master Mar 10, 2022
@aminalaee aminalaee deleted the add-masked-fields-option branch March 11, 2022 07:44
barrachri added a commit to barrachri/django-auditlog that referenced this pull request May 8, 2022
* master:
  Remove default_app_config configuration
  Fix lint entry in tox.ini
  Drop Django 2.2 support.
  [pre-commit.ci] pre-commit autoupdate
  Fix small typo
  Add mask_fields argument in register (jazzband#310)
  Use pre-commit as lint command
  Add black and isort to .pre-commit-config.yaml
  Replace assertTrue with assertEqual
  enable use of replica database (jazzband#359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow fields to be logged as sensitive/masked/no-value log entries
3 participants