Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark LogEntryAdminMixin methods output as safe where required #167

Merged

Conversation

AceFire6
Copy link
Contributor

@AceFire6 AceFire6 commented Mar 1, 2018

As per my comment (#159 (comment)). I believe using format_html to be a better solution to that proposed in #159.

  • Remove allow_tags as they've been deprecated as of Django 2.0
  • Use format_html to provide conditional escaping and mark_safe functionality

@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #167 into master will decrease coverage by 0.09%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #167     +/-   ##
=========================================
- Coverage   83.36%   83.26%   -0.1%     
=========================================
  Files          19       19             
  Lines         511      508      -3     
=========================================
- Hits          426      423      -3     
  Misses         85       85
Impacted Files Coverage Δ
src/auditlog/mixins.py 80% <60%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fced0a6...381d7b5. Read the comment docs.

Copy link
Contributor

@audiolion audiolion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR

@audiolion audiolion merged commit bc886fa into jazzband:master Mar 1, 2018
@AceFire6 AceFire6 deleted the jethro/add/django2_support_to_admin branch May 21, 2018 11:52
@robguttman
Copy link
Contributor

@jjkester is this ready for a new 0.4.6 release?

@jjkester
Copy link
Collaborator

@robguttman Releases are a bit ad-hoc currently, I might investigate whether it is feasible to release automatically by creating a Travis job for that to take the manual interaction out of the equation.

As for now, I'm all for a new release, but I'm traveling for work at the moment, I'll see what I can do, but don't expect a release in a couple of days. Thanks for your patience.

@robguttman
Copy link
Contributor

@jjkester, understood - we appreciate your efforts on this great lib!

@robguttman
Copy link
Contributor

@jjkester, when do you think you can do a 0.4.6 release?

@jjkester
Copy link
Collaborator

@robguttman Thanks for the heads-up. I created a PR (#183) to automatically deploy to Travis. I could not merge it right away due to failing tests. These need to be addressed, and I kind of hoped after a try myself that someone else would pick it up since my time is very limited right now.

Since I'm (still) traveling (again), I don't have the credentials to manually release a version available right now. If you want to look at the failing tests, feel free, so we can get #183 merged and the releases going. Otherwise you would have to wait since I won't be able to release manually for a couple of weeks.

@robguttman
Copy link
Contributor

@jjkester, the Travis tests look like they all passed. What seems to have "failed" are the code coverage targets - but perhaps I'm reading the results wrong? When I try to look at the codecov report I just see this message:

Missing base report.
Unable to compare commits because the base of the compare did not upload a coverage report.

What next to release 0.4.6?

@texnic
Copy link

texnic commented Jul 21, 2019

What is the current status? Any changes since last autumn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants