Unify all command datetime inputs #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidag
force-pushed
the
unify-datetime-cli-input
branch
2 times, most recently
from
a04f92b to
5517841
Compare
davidag
changed the title
davidag
force-pushed
the
unify-datetime-cli-input
branch
3 times, most recently
from
bdf6681 to
abc29a4
Compare
|
I have cleaned up and rebased this PR. It should be ready for reviewing @k4nar. |
k4nar
previously approved these changes
Nov 28, 2019
|
@davidag A last conflict to solve and we are good to go! 🙏 |
Fixes jazzband#292 - Rename DateParamType to DateTimeParamType because it now supports times in the following formats: 'HH:mm' and 'HH:mm:ss'. - Remove TimeParamType by supporting its formats in DateTimeParamType. - Add the new valid formats to tests (previously invalid). - Tests for the 'stop' command now support the same dates/times than the other commands.
davidag
force-pushed
the
unify-datetime-cli-input
branch
from
abc29a4 to
73ad3b0
Compare
|
@jmaupetit @k4nar: conflict solved 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows things like these:
The changes are:
DateParamTypetoDateTimeParamTypebecause it now supportstimes in the following formats: 'HH:mm' and 'HH:mm:ss'.
TimeParamTypeby supporting its formats inDateTimeParamType.Fixes #292 and improves #278