-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use app folder for main JDownloader files #102
Conversation
4d9ab54
to
4720ee1
Compare
related #94 |
If you accept this PR, I can update the readme file, too. I also can change the paths and names if you think others are better suited. They were just my preference. |
@egvimo thank you for your contribution. This is an effective implementation of #94 (comment) (which is still waiting for vote BTW) but I think it could have been easier. Yes please change the README.md as everything must be related in the same commit. IMHO implementing only the |
cd3f8b0
to
90fa005
Compare
@jaymoulin You're right. I've reverted all my preferences and optimizations. Now only the new |
After some thoughts I think |
90fa005
to
bf6a60d
Compare
I've changed the folder to |
This PR moves the main app to a separate folder (
app
). This way this directory can be mounted as a volume which persists the data after an update.THIS IS A BREAKING CHANGE! Because of the extra directory layer the mounts has to be changed.
I've created an image and tested this on my Kubernetes cluster. A small example for a pod:
Fixes: #94, #91, #82 and maybe other related.