Skip to content

docs: retract subset-200 Single-hop pick after full-1540 validation - #67

Merged
jaylfc merged 1 commit into
masterfrom
docs/full1540-validation-may11
May 11, 2026
Merged

docs: retract subset-200 Single-hop pick after full-1540 validation#67
jaylfc merged 1 commit into
masterfrom
docs/full1540-validation-may11

Conversation

@jaylfc

@jaylfc jaylfc commented May 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Full-1540 validation of the May 7-9 hardware-tier table revealed the llama3.1:8b + RRF + temp 0.2 "Best Single-hop" recipe regresses from 0.65 SH (subset 200) to 0.49 SH (full 1540) under gemma4:e2b — a -0.16 collapse.
  • The leader recipe (qwen3.5:9b + mem0_additive + temp 0.2) generalises within noise (-0.01 SH), so production default holds with refreshed numbers (Overall 0.71 → 0.68).
  • README row removed for llama+RRF; surviving subset-200 rows (llama+mem0+temp 0, mistral+rrf+0.2) carry explicit "subset 200, full-1540 validation pending" footnotes.
  • New callout above the table makes the subset → full discipline explicit going forward.
  • docs/benchmarks.md gains a "Subset 200 → full 1540 validation" subsection under the temp-sweep section with the side-by-side comparison and methodology takeaways.

Status of the underlying bench

  • Cell 3 (qwen+mem0+0.2 full 1540) — dual-judge complete: q34b 0.54 / 0.28 SH, g4e2b 0.68 / 0.55 SH.
  • Cell 4 (llama+RRF+0.2 full 1540) — gemma4:e2b rescore complete (0.64 / 0.49 SH). qwen3:4b rescore still running at ~325/1540, ETA ~6h. q34b half will land as a follow-up commit on this branch.

The gemma4:e2b half alone is enough to flip the Single-hop ranking, so shipping the retraction now rather than waiting another ~6h.

Test plan

  • AST + flag plumbing already validated when the bench script was queued
  • Numbers cross-checked against /tmp/llama_rrf_gapfill_summary.tsv on the bench host
  • Add cell-4 qwen3:4b rescore numbers when they land

Summary by CodeRabbit

  • Documentation
    • Updated LoCoMo benchmark results with re-evaluation on expanded validation set
    • Revised generator recommendations for the 12 GB GPU tier based on latest performance findings
    • Added post-processing documentation explaining validation methodology and generalization analysis

Review Change Stack

…ailure

The May 7-9 12 GB hardware-tier table promoted llama3.1:8b + RRF + temp 0.2 as
the best Single-hop recipe based on a 200-QA subset result of 0.65 SH under
gemma4:e2b judge. Validating that pick at the full 1540 QAs measured Single-hop
at 0.49 — a -0.16 regression that puts it below the qwen3.5:9b + mem0_additive
leader's 0.55 SH on the same dataset.

Subset 200 over-represented questions where llama+RRF won at our generator/recipe
pairing. The leader recipe (qwen+mem0+temp 0.2) generalises within noise (-0.01
SH from subset 200 to full 1540), so the production default holds and gets a
small Overall number refresh (0.71 -> 0.68).

README changes:
  - Headline number now cites full-1540 g4e2b (0.68 / 0.55 SH) instead of the
    subset-200 figure
  - Recipe in the headline updated to mem0_additive + temp 0.2 (the actual
    leader; previous text named the older RRF-default recipe)
  - 'Best factual recall: llama+RRF' row removed
  - Surviving subset-200 rows (llama+mem0+temp 0, mistral+rrf+temp 0.2) carry
    explicit subset-200 footnotes pending full-1540 validation
  - New callout above the table explaining the subset->full discipline going
    forward

docs/benchmarks.md adds a 'Subset 200 -> full 1540 validation' subsection
under the temp-sweep section with the side-by-side comparison and methodology
takeaways. Cell 4 qwen3:4b rescore is still running at time of this commit
(~6h remaining); only the gemma4:e2b half is reflected. q34b half lands as a
follow-up commit.
@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Documentation updates to the LoCoMo benchmark section add full 1540-QA validation results for temperature-sweep recipes, reporting subset-to-full score deltas and revising the README generator recommendations table based on qwen3.5:9b generalization and llama3.1:8b regression.

Changes

LoCoMo Benchmark Rejudge Results

Layer / File(s) Summary
Validation Results Documentation
docs/benchmarks.md
New "Subset 200 → full 1540 validation" section documents May 7–9 temperature-sweep re-runs on full dataset, reporting subset-to-full deltas for qwen3.5:9b + mem0_additive (generalizing) and llama3.1:8b + RRF (single-hop regression), with notes on remaining Cell-4 re-scoring work.
README Generator Recommendations
README.md
LoCoMo "ext rejudge" headline description and 12 GB GPU "Recommended generators" table replaced to reflect full-1540 validation status instead of 200-QA subset framing; llama3.1:8b + RRF removed due to full-scale single-hop regression; revised table footnotes and generator entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • jaylfc/taosmd#63: Earlier PR updating May-5 LoCoMo subset results; this PR supersedes with full-1540 rejudge deltas and revised generator recommendations.
  • jaylfc/taosmd#65: Related PR re-evaluating LoCoMo results under different judges and revising generator recommendations based on regression detection.
  • jaylfc/taosmd#56: Related PR modifying LoCoMo leaderboard and reporting generator-level deltas, including regression metrics.

Poem

🐰 The benchmarks hop from 200 to full,
Qwen leaps true, but Llama's pull
Regresses on the single track—
Our table gains the honest facts back.
Results validated, rows recast,
Best practices holding fast! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly aligns with the PR's main objective: retracting a Single-hop model recommendation after full-1540 validation revealed regression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/full1540-validation-may11

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 11, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • README.md - Updated benchmark numbers and table based on full-1540 validation
  • docs/benchmarks.md - Added validation subsection with methodology and results

Reviewed by grok-code-fast-1:optimized:free · 82,435 tokens

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 184-185: The README claims “same predictions, same recipe” but
attributes the strict-score 0.557 to the qwen3.5:9b + mem0_additive recipe while
the actual strict value for that recipe under the strict judge (qwen3:4b) is
0.54; replace the incorrect 0.557 string with 0.54 (and update the repeated
mentions of 0.557 at the other occurrences that refer to the same-recipe claim)
or alternatively clarify that 0.557 is from the RRF leaderboard recipe (not the
same-recipe run) so the sentence correctly contrasts 0.54 (strict, same
predictions) vs 0.68 (lenient judge), ensuring the recipe string
(--retrieval-top-k 20 --adjacent-turns 2 --llm-query-expansion --fusion
mem0_additive --gen-temp 0.2) and judge names (qwen3:4b, gemma4:e2b) remain
aligned with the corrected numbers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 41eaaf99-649e-4782-a2e2-ce91cb7ded81

📥 Commits

Reviewing files that changed from the base of the PR and between d54914e and 93e12cf.

📒 Files selected for processing (2)
  • README.md
  • docs/benchmarks.md

Comment thread README.md
Comment on lines +184 to 185
**0.557 ext rejudge** on the full 1540-QA test set under our strict default judge (`qwen3:4b`) — and **0.68 overall / 0.55 Single-hop** on the **full 1540 QAs** under the lenient matched-with-paper-SOTA judge (`gemma4:e2b`). Same predictions, same recipe (qwen3.5:9b + `--retrieval-top-k 20 --adjacent-turns 2 --llm-query-expansion --fusion mem0_additive --gen-temp 0.2`), only the judge differs. Both numbers are honest measurements of the same system; published numbers from Mem0/EMem/Zep use a lenient frontier judge (gpt-4o-mini), so 0.68 is the more apples-to-apples comparison number with their headlines. See [docs/benchmarks.md](docs/benchmarks.md#judge-sensitivity--what-we-are-really-measuring) for the full multi-judge analysis.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix strict-score attribution mismatch for the “same recipe” claim.

Line 184 says the strict score is 0.557 for qwen3.5:9b + mem0_additive + temp 0.2, but Line 192 (and the new full-1540 validation section in docs) reports 0.54 for that recipe under qwen3:4b.
If the recipe is truly “same predictions, only judge differs,” the strict value should be 0.54; 0.557 appears to be from the RRF leaderboard recipe.

Suggested README fix
-**0.557 ext rejudge** on the full 1540-QA test set under our strict default judge (`qwen3:4b`) — and **0.68 overall / 0.55 Single-hop** on the **full 1540 QAs** under the lenient matched-with-paper-SOTA judge (`gemma4:e2b`). Same predictions, same recipe (qwen3.5:9b + `--retrieval-top-k 20 --adjacent-turns 2 --llm-query-expansion --fusion mem0_additive --gen-temp 0.2`), only the judge differs.
+**0.54 ext rejudge** on the full 1540-QA test set under our strict default judge (`qwen3:4b`) — and **0.68 overall / 0.55 Single-hop** on the **full 1540 QAs** under the lenient matched-with-paper-SOTA judge (`gemma4:e2b`). Same predictions, same recipe (qwen3.5:9b + `--retrieval-top-k 20 --adjacent-turns 2 --llm-query-expansion --fusion mem0_additive --gen-temp 0.2`), only the judge differs.

Also applies to: 192-193

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 184 - 185, The README claims “same predictions, same
recipe” but attributes the strict-score 0.557 to the qwen3.5:9b + mem0_additive
recipe while the actual strict value for that recipe under the strict judge
(qwen3:4b) is 0.54; replace the incorrect 0.557 string with 0.54 (and update the
repeated mentions of 0.557 at the other occurrences that refer to the
same-recipe claim) or alternatively clarify that 0.557 is from the RRF
leaderboard recipe (not the same-recipe run) so the sentence correctly contrasts
0.54 (strict, same predictions) vs 0.68 (lenient judge), ensuring the recipe
string (--retrieval-top-k 20 --adjacent-turns 2 --llm-query-expansion --fusion
mem0_additive --gen-temp 0.2) and judge names (qwen3:4b, gemma4:e2b) remain
aligned with the corrected numbers.

@jaylfc
jaylfc merged commit c58a1d9 into master May 11, 2026
2 checks passed
@jaylfc
jaylfc deleted the docs/full1540-validation-may11 branch May 11, 2026 13:43
jaylfc added a commit that referenced this pull request May 12, 2026
…68)

* docs: cell-4 qwen3:4b rescore — both full-1540 cells now dual-judge complete

Follow-up to PR #67. Cell 4 (llama3.1:8b + RRF + temp 0.2 full 1540) qwen3:4b
rescore landed at 0.53 Overall / 0.27 SH, vs cell 3's 0.54 / 0.28. Both judges
now agree the qwen+mem0 leader wins Overall and Single-hop at full scale —
subset 200 was over-representing the slice where llama+RRF won.

Removes the 'qwen3:4b rescore still running' note and adds a small
both-judges-both-cells summary table so readers don't have to cross-reference
two paragraphs.

* ci: retrigger Kilo (sandbox provisioning error on first run)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant