Skip to content

whitespace residue in two merged gate/docs PRs: a stray docstring space moved instead of being removed, and a README lost its trailing newline - #356

Closed
jaylfc wants to merge 1 commit into
masterfrom
exec/tsk-sgia5s
Closed

whitespace residue in two merged gate/docs PRs: a stray docstring space moved instead of being removed, and a README lost its trailing newline#356
jaylfc wants to merge 1 commit into
masterfrom
exec/tsk-sgia5s

Conversation

@jaylfc

@jaylfc jaylfc commented Aug 18, 2026

Copy link
Copy Markdown
Owner

CARD TITLE (intent, not commit subject): whitespace residue in two merged gate/docs PRs: a stray docstring space moved instead of being removed, and a README lost its trailing newline

Autonomous build of board card tsk-sgia5s.

REVIEW WARNING (automated): this card's text asks for tests, but the diff changes no test file. Either the acceptance criteria are unmet or the card needs correcting. Do not merge without resolving this.

Files:
benchmarks/data/README.md | 2 +-
changelog.d/tsk-sgia5s-whitespace-fix.md | 4 ++++
scripts/normalise_handle_gate.py | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 28ef0845-8c8e-4e3d-a0bb-34e81458e98d

📥 Commits

Reviewing files that changed from the base of the PR and between e759336 and a2f0426.

📒 Files selected for processing (3)
  • benchmarks/data/README.md
  • changelog.d/tsk-sgia5s-whitespace-fix.md
  • scripts/normalise_handle_gate.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • benchmarks/data/README.md
  • changelog.d/tsk-sgia5s-whitespace-fix.md
  • scripts/normalise_handle_gate.py

Reviewed by step-3.7-flash · Input: 24.9K · Output: 3.2K · Cached: 94.2K

@jaylfc

jaylfc commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

CLOSING. The two code changes in this PR are correct — the docstring dedent removes the stray leading space, and the README edit restores the trailing newline. Neither is being rejected on its merits. This PR is closed for two reasons that are both about the vehicle, not the work.

1. Its card tsk-sgia5s was already closed before this PR existed.

tsk-sgia5s was closed on a block earlier today, when PR #352 could not land: the docstring half conflicted, and the README half was not in that diff at all. The replacement card is tsk-lkctqr, filed at the same moment, and it is already built as PR #358. This PR and #358 touch the same three files for the same purpose, so only one can land and the sanctioned one is #358.

The dispatch that produced this PR (bus 3174) landed ~107 seconds after the close, so this is a race, not a lane error. Recording it as such.

2. Independently, this PR reintroduces the exact defect that #351 fixed.

The new changelog fragment does not end in a newline:

changelog.d/tsk-sgia5s-whitespace-fix.md, last byte = 0x60   ('`')

Measured across every fragment on master dddbb5d7: 29 fragments checked, 0 missing a trailing newline. #351 (tsk-v2pr2b) fixed that class this morning and it currently holds with no exceptions. Merging this would make its fragment the only one on master without a trailing newline, so the next appended entry concatenates onto it — which is precisely the bug #351 closed.

That is worth stating plainly because this is a whitespace-residue card: the fix would have shipped a new whitespace residue. For contrast, #358's fragment ends 0x0a.

Not deleting the branch. exec/tsk-sgia5s stays fetchable, as with every close.

No new card is needed — tsk-lkctqr already carries this work, and it is under review as #358 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant