Revise PR #323/#317: the branch was pushed at the already-blocked commit, so none of the five durable-cron blockers were touched - #337
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 56 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| @@ -0,0 +1,2 @@ | |||
| ### Fixed | |||
There was a problem hiding this comment.
SUGGESTION: Changelog says "721-line" but scripts/resume_arm_time.py is 752 lines
The line count in the changelog does not match the actual file size.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 105.1K · Output: 23K · Cached: 806.7K |
MERGE. Fifth attempt on this chain and the first that did the work. All five blockers fixed, each with a real red-first control.Follow-up card: The cheap check this card was filed over — this time it passes
Non-empty, as the acceptance required. Merge-base is Blockers A–E, each re-measured rather than inherited
The Red-first, proven independentlyThe new test file, copied unchanged onto the blocked tree Every one of A–E has a test that goes red on the unfixed code. That is what the last four attempts could not show. Suite1550 passed, 12 skipped on a trial merge into The one new defect — carded as
|
…tab lines name the canonical in-repo script (#354) Card tsk-bse2el. Replaces the hardcoded /home/jay/.taos-fleet-tools/resume_arm_time.py in system_crontab_block and do_fire with _HELPER_PATH = os.path.realpath(__file__). WHY THIS MATTERED MORE THAN THE CARD SAID The out-of-repo path the crontab lines named is not just a different copy, it is a stale pre-#337 one: md5 7c54e86e32 / 40843 bytes vs the repo's 446505544c / 42188 bytes, 45 lines of divergence, and its do_fire has NO A2A bus posting at all. On master an armed resume fired, wrote a log line, and notified nobody. Verified on a TRIAL MERGE into origin/master dddbb5d (merge-base re-derived as 72ade2c after #355 moved master mid-review), never on the PR head. - Real CLI (`resume_arm_time.py 2026-08-18T07:00:00+00:00`, read-only): master emits the .taos-fleet-tools path; the trial merge emits the invoking checkout's own script. - Mutation analysis: against the OLD impl the 4 touched tests all fail, but every one fails with `AttributeError: no attribute '_HELPER_PATH'`, which only proves the symbol is new. Against a MUTANT that DEFINES _HELPER_PATH but hardcodes it back, only 2 fail: test_do_fire_posts_resume_due_to_bus FAILED <- discriminates test_do_fire_bus_failure_writes_visible_record FAILED <- discriminates test_system_crontab_block_names_usr_bin_python3 PASSED <- vacuous wrt this defect test_do_fire_runs_as_subprocess PASSED <- vacuous wrt this defect The discriminating pair anchors on SCRIPT, an origin independent of the implementation. Followed up as tsk-vqfjsm; genuine coverage exists, so not a blocker. - Changelog fragment ends 0x0a, so it does not reintroduce the #351 defect. - Conflict markers, deleted-symbols guard, handle gate, witness gate: clean. - Full suite on the trial merge: 1617 passed, 12 skipped. Reconciles as 1617 = 1617 + 0. STATED LIMITATIONS - The emitted path now depends on WHERE the script is run. From a worktree or temp copy it pins a path that will be deleted; since the line is `<helper> --fire ... && (crontab -l | grep -v ...) | crontab -`, a missing helper short-circuits the && and the self-removal never runs, turning a one-shot into a permanent annual entry. Filed as tsk-bxdfvz. - Nothing here reconciles the two copies. The stale .taos-fleet-tools file is still on disk and still 45 lines behind; this only stops the repo copy pointing at it. Untracked. - os.path.realpath resolves symlinks, so a symlink install would be pinned by its target. No such install exists today. - My first suite run on this PR reported 1 failure. That was my own contaminated worktree (I reverted the tree mid-run), not the PR. Rebuilt, proved impl+tests by md5 before and after, re-ran clean. Recorded on the PR.
1 participant
CARD TITLE (intent, not commit subject): Revise PR #323/#317: the branch was pushed at the already-blocked commit, so none of the five durable-cron blockers were touched
Autonomous build of board card tsk-y62mpe.
Files:
taosmd/remote.py | 5 +
taosmd/service.py | 65 +-
tests/test_a2a_channels.py | 65 ++
tests/test_measure_upstream_propagation.py | 347 ++++++++++
tests/test_normalise_handle_gate.py | 323 ++++++++-
tests/test_resume_arm_time.py | 301 +++++++++
tests/test_witness_gate.py | 54 +-
25 files changed, 2523 insertions(+), 43 deletions(-)