Conversation
…ncludesCreatedEdit includesCreatedEdit means 'this review was edited', not 'has inline comments', so inline-only bot reviews (CodeRabbit's normal shape) were rejected by the anchoring gate. Use comments.totalCount > 0 instead.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| # Reconstruct the pre-fix logic that relied on includesCreatedEdit | ||
| with open(os.path.join("scripts", "merge-gate", "check_bot_anchoring.sh")) as f: | ||
| buggy_script = f.read().replace( |
There was a problem hiding this comment.
SUGGESTION: Regression test uses string replacement to reconstruct the buggy logic
If the implementation is later refactored to a different approach (e.g., extracting the inline-comment check to a helper function or using a different field), the .replace() silently fails to match. The buggy script would then contain the current fixed logic, and because the fixture's comments.totalCount is 3, the test would unexpectedly return SUCCESS instead of FAILED — masking a regression in the test itself.
Consider asserting against the old field directly (includesCreatedEdit) instead of patching the source string, or adding a dedicated fixture that has comments: null to also cover the missing-field edge case.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 69.5K · Output: 15K · Cached: 287.4K |
|
Closing, and the reason is a mechanism failure on my side, not a lane failure. This rebuild carries the identical blocker to #277: Why it came back unchanged. The lane never saw that review. It was posted on #277, which I closed to free the card, and the executor builds a lane's prompt from the card BODY only — comments never reach it. So closing a blocked PR to unblock its card also throws away the review that explains what was wrong. That is my error to fix, and I am fixing it by refiling the card with the data source spelled out in the body rather than by asking anyone to re-derive it. Two things here are genuinely better than #277 and should survive into the rebuild: deriving the buggy comparison script from the real one by string replacement, instead of hand-copying it ( Branch |
1 participant
CARD TITLE (intent, not commit subject): fix(merge-gate): check_bot_anchoring counts inline comments, not includesCreatedEdit
Autonomous build of board card tsk-e4cpto.
includesCreatedEdit means 'this review was edited', not 'has inline
comments', so inline-only bot reviews (CodeRabbit's normal shape) were
rejected by the anchoring gate. Use comments.totalCount > 0 instead.
Files:
scripts/merge-gate/check_bot_anchoring.sh | 2 +-
tests/fixtures/merge_gate/pr_inline_only.json | 15 +++++++++++
tests/test_merge_gate.py | 37 +++++++++++++++++++++++++++
3 files changed, 53 insertions(+), 1 deletion(-)