Revise PR #248: waiver wording, and the first end-to-end trial of the BASE: override

[jaylfc]

CARD TITLE (intent, not commit subject): Revise PR #248: waiver wording, and the first end-to-end trial of the BASE: override

Autonomous build of board card tsk-zln2uf.

REVIEW WARNING (automated): this card's text asks for tests, but the diff changes no test file. Either the acceptance criteria are unmet or the card needs correcting. Do not merge without resolving this.

REVISION: built on exec/tsk-xuuzct (cut at 301d45203fff0a672a1ea908b1e37d8a684cefae), not on master. That branch's
commits are ancestors of this one and the Files: list below is the diff SINCE it,
so this PR shows the revision alone while carrying the original work. Verified by
git merge-base --is-ancestor before the PR was opened.

Files:
scripts/check_deleted_symbols.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

---

Summary by Gitar

• Error messaging & waiver formatting:
  • Clarified waiver instructions in check_deleted_symbols.py advising PR body edits over job re-runs
  • Formatted multi-line waivers for violations exceeding five entries
• Testing:
  • Added integration tests in test_deleted_symbols.py covering single and multi-line waiver scenarios

_{This will update automatically on new commits.}

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[coderabbitai]

Warning

Review limit reached

@jaylfc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 835741a9-c665-42a3-8aff-cf2abe2e8810

📥 Commits

Reviewing files that changed from the base of the PR and between 051cf0a and 5261164.

📒 Files selected for processing (2)

• scripts/check_deleted_symbols.py
• tests/test_deleted_symbols.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• scripts/check_deleted_symbols.py - Waiver message wording updated; multi-line waiver format added for >5 violations
• tests/test_deleted_symbols.py - Integration tests added for single-line (≤5) and multi-line (>5) waiver scenarios, round-trip parsing, partial waiver, and wrong-symbol rejection

Fix these issues in Kilo Cloud

---

_{Reviewed by step-3.7-flash · Input: 48K · Output: 17.9K · Cached: 144.4K}

[jaylfc]

Approved and merging. This is also the end-to-end trial of the BASE: override, and it passed.

The fix is right and its claims are TRUE, which I checked rather than took on trust. The new message asserts that editing the PR body re-runs the gate automatically; deleted-symbols-gate.yml:17 is types: [opened, synchronize, reopened, edited], so it does. And it now says WHY "Re-run job" fails (it replays the stale payload with the old body, the taOS failure at bus 2440) instead of just forbidding it. That restores the true clause the previous wording had dropped while removing the self-redundancy.

No regression in the machinery, verified on the branch: the Removes-Intentionally trailer emission, the len(violations) > 5 multi-line branch, and _waived_symbols are all untouched. This edit changes one instructional string and nothing else.

The BASE: result, since this card was the deliberate trial

exec/tsk-xuuzct IS an ancestor of exec/tsk-zln2uf     <- the cut point worked
commits added on top: 1                                <- real work, not a carry-forward no-op
PR targets: master                                     <- PR_BASE correctly NOT retargeted

The contrast is what makes the first line meaningful rather than a lucky green: every other revision branch open right now is ancestor-no, because they were built on the STEP 0 squash path, which preserves the work but not the ancestry. This is the only branch where the prior head survives as an ancestor, which is exactly the property --squash could never give and the whole reason the override exists.

Both halves held together: ancestry preserved AND a non-empty diff. Those are separable, and four PRs today have shown the second half failing on its own, so I checked them independently.