feat(a2a): verify-and-warn mode for bus registry-auth (#138 Phase 2) - #181
Conversation
…eld behind a2a_auth_enforce) - config.py: get/set_a2a_auth_enforce (key a2a_auth_enforce, env TAOSMD_A2A_AUTH_ENFORCE, default False) - http_server.py: restructure _handle_a2a_send auth block to collect warn_reason before deciding enforce vs. log-and-accept; update Security note docstring to document both modes - tests: add warn_server fixture + 4 warn-mode tests (caplog assertions); update enforced_server, authed_server, iss_pinned_server, and test_send_rejected_expired_grant to set a2a_auth_enforce=True so existing rejection assertions hold under new warn default
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| Resolution order: | ||
|
|
||
| 1. ``TAOSMD_A2A_AUTH_ENFORCE`` env var (``"1"`` or ``"true"`` = True) |
There was a problem hiding this comment.
SUGGESTION: Docstring inconsistency — only "1" and "true" are documented as truthy here, but the implementation also accepts "yes". Either document "yes" in the docstring or tighten the env parser to match it.
| 1. ``TAOSMD_A2A_AUTH_ENFORCE`` env var (``"1"`` or ``"true"`` = True) | |
| 1. ``TAOSMD_A2A_AUTH_ENFORCE`` env var (``"1"``, ``"true"``, or ``"yes"`` = True) |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Reviewed by minimax-m3 · Input: 36.8K · Output: 4.2K · Cached: 222.7K |
…fresh STATUS with #181 + canary verified
1 participant
Phase 2 of agent-identity auth (#138), bus side. Adds VERIFY-AND-WARN so the registry-JWT verifier can be activated on the live bus without breaking agents still on self-asserted handles. The enforce flip stays held behind a config flag for @taOS-dev's signal.
config.get/set_a2a_auth_enforce(keya2a_auth_enforce, default False = warn; envTAOSMD_A2A_AUTH_ENFORCE), mirrorsget_serve_dashboard._handle_a2a_send: when a verifier is configured, computes onewarn_reasonacross the three checks (missing token / authorize+sub==from / a2a_send grant), reads enforce per request. Warn (default): log + accept (message still sent + stored). Enforce: reject with the original 401/403 statuses. No verifier configured: unchanged (bus trusts the handle).NON-BREAKING by default: warn mode, no registry_url set, no enforce enabled. The verifier stays dormant until registry_url is configured; activation + the eventual enforce flip are operational steps @taOS-dev coordinates. Whole-branch reviewed; full suite 1027 passed.