fix: address bot-review findings on the generator-profile PRs

dashboard/src/components/GeneratorProfileSelector.tsx

@@ -13,9 +13,15 @@ export function GeneratorProfileSelector() {
 
   // Fetch agent list once for scope options
   useEffect(() => {
-    void getStats().then((s) => {
-      setAgentNames(s.top_agents.map((a) => a.name).filter(Boolean));
-    });
+    void getStats()
+      .then((s) => {
+        setAgentNames(s.top_agents.map((a) => a.name).filter(Boolean));
+      })
+      .catch((err: unknown) => {
+        // Surface via the existing ErrorBanner so the user sees a signal rather
+        // than silently falling back to the global "all" scope only.
+        setError(err instanceof Error ? err.message : String(err));
+      });
   }, []);
 
   const scopeOptions = useMemo(() => {

taosmd/catalog_pipeline.py

@@ -167,7 +167,7 @@ async def index_day(
         # The memory model is a system-wide setting. When configured it
         # overrides the auto-detected model; when unset, the detected model
         # (prior behaviour) is kept as the fallback.
-        model = resolve_memory_model(model)
+        model = resolve_memory_model(fallback=model)
 
         # --- Stage 1b: Intake Classification (taxonomy filing) ---
         classify_results = []

taosmd/cli.py

@@ -173,7 +173,11 @@ def _generator_profile_set(profile_id: str, agent=None, data_dir=None) -> int:
         print(f"error: unknown profile {profile_id!r}", file=sys.stderr)
         return 1
     if agent:
-        agents.set_agent_generator_profile(agent, profile_id, data_dir=data_dir)
+        try:
+            agents.set_agent_generator_profile(agent, profile_id, data_dir=data_dir)
+        except agents.AgentNotFoundError:
+            print(f"error: agent {agent!r} is not registered", file=sys.stderr)
+            return 1
         print(f"agent {agent}: generator profile = {profile_id}")
     else:
         config.set_generator_profile(profile_id, data_dir=data_dir)
@@ -1776,11 +1780,11 @@ def main(argv: list[str] | None = None) -> int:
 
     if args.cmd == "generator-profile":
         if args.generator_profile_cmd == "list":
-            return _generator_profile_list()
+            return _generator_profile_list(data_dir=args.data_dir)
         if args.generator_profile_cmd == "show":
-            return _generator_profile_show(args.profile_id)
+            return _generator_profile_show(args.profile_id, data_dir=args.data_dir)
         if args.generator_profile_cmd == "set":
-            return _generator_profile_set(args.profile_id, agent=args.agent)
+            return _generator_profile_set(args.profile_id, agent=args.agent, data_dir=args.data_dir)
 
     parser.print_help()
     return 1

taosmd/config.py

@@ -253,15 +253,17 @@ def get_runtime_overrides(data_dir=None) -> dict:
     return out
 
 
-def resolve_memory_model(fallback: str | None = None, data_dir=None) -> str | None:
+def resolve_memory_model(fallback: str | None = None, agent: str | None = None, data_dir=None) -> str | None:
     """Resolve the active generator model: pin > profile(tier) > fallback.
 
+    When agent is provided, a per-agent generator profile is consulted before
+    the global profile, mirroring the resolution order in resolve_generator.
     Delegates to generator_profiles.resolve_generator (lazy import to avoid a
     cycle). Returns None when resolution yields the empty (retrieval-only)
     value AND no fallback was given, preserving the historical None contract.
     """
     from . import generator_profiles  # lazy: avoids config<->profiles cycle
-    resolved = generator_profiles.resolve_generator(fallback=fallback, data_dir=data_dir)
+    resolved = generator_profiles.resolve_generator(agent=agent, fallback=fallback, data_dir=data_dir)
     return resolved or None
 
 

taosmd/emem_event_lift.py

@@ -137,7 +137,7 @@ async def lift_edu_to_triples(
     if not model:
         from .config import resolve_memory_model  # noqa: PLC0415
 
-        model = resolve_memory_model("llama3.1:8b")
+        model = resolve_memory_model(fallback="llama3.1:8b")
     messages = [
         {"role": "system", "content": _system_prompt()},
         {"role": "user", "content": _ONESHOT_INPUT},

taosmd/generator_profiles.py

@@ -99,7 +99,10 @@ def resolve_generator(agent: str | None = None, *, fallback: str | None = None,
         return pin
     pid = None
     if agent:
-        pid = _agents.get_agent_generator_profile(agent, data_dir=data_dir)
+        try:
+            pid = _agents.get_agent_generator_profile(agent, data_dir=data_dir)
+        except _agents.AgentNotFoundError:
+            pid = None
     pid = pid or _config.get_generator_profile(data_dir) or default_profile_id()
     prof = get_profile(pid)
     if prof is not None:

taosmd/http_server.py

@@ -1045,7 +1045,7 @@ def _handle_generator_profile_post(self) -> None:
                     _agents.set_agent_generator_profile(agent, pid, data_dir=data_dir)
                 else:
                     _cfg.set_generator_profile(pid, data_dir=data_dir)
-            except Exception as exc:  # e.g. AgentNotFoundError
+            except (_agents.AgentNotFoundError, ValueError) as exc:
                 self._send_json(400, {"error": str(exc)})
                 return
             profiles = [

taosmd/memory_extractor.py

@@ -260,7 +260,7 @@ async def process_conversation_turn(
 
         resolved_model = extraction_model
         if not resolved_model or resolved_model == "default":
-            resolved_model = resolve_memory_model() or "default"
+            resolved_model = resolve_memory_model(agent=agent_name or "default") or "default"
         facts = await extract_facts_with_llm(
             text, llm_url, http_client,
             agent_name=agent_name or "default",

taosmd/webui/index.html

@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <meta name="description" content="taOSmd — local memory inspector and A2A channel monitor" />
     <title>taOSmd</title>
-    <script type="module" crossorigin src="./assets/index-D0AgbSmp.js"></script>
+    <script type="module" crossorigin src="./assets/index-BYD--bJq.js"></script>
     <link rel="stylesheet" crossorigin href="./assets/index-C48QvJab.css">
   </head>
   <body>

tests/test_config_memory_model.py

@@ -69,7 +69,7 @@ def test_corrupt_file_treated_as_unset(data_dir):
 
 def test_resolve_prefers_global_over_fallback(data_dir):
     config.set_memory_model("ollama:qwen3:4b")
-    assert config.resolve_memory_model("fallback-model") == "ollama:qwen3:4b"
+    assert config.resolve_memory_model(fallback="fallback-model") == "ollama:qwen3:4b"
 
 
 def test_resolve_uses_fallback_when_unset(data_dir, monkeypatch):
@@ -80,7 +80,7 @@ def test_resolve_uses_fallback_when_unset(data_dir, monkeypatch):
     from taosmd import generator_profiles as gp
     monkeypatch.setattr(gp.recipes, "local_probe", lambda: {"host": {}})
     monkeypatch.setattr(gp.recipes, "tier_of", lambda info: "unknown-tier")
-    assert config.resolve_memory_model("fallback-model") == "fallback-model"
+    assert config.resolve_memory_model(fallback="fallback-model") == "fallback-model"
 
 
 def test_resolve_none_fallback_when_unset(data_dir, monkeypatch):

tests/test_generator_profile_agent.py

@@ -6,12 +6,15 @@
 def test_agent_generator_profile_roundtrip(tmp_path):
     # register_agent (module-level) does not take data_dir; use the registry
     # directly against tmp_path, exactly like tests/test_agents.py does.
-    agents.AgentRegistry(tmp_path).register_agent("alice")
+    registry = agents.AgentRegistry(tmp_path)
+    registry.register_agent("alice")
     assert agents.get_agent_generator_profile("alice", data_dir=tmp_path) is None
     agents.set_agent_generator_profile("alice", "factual-recall", data_dir=tmp_path)
     assert agents.get_agent_generator_profile("alice", data_dir=tmp_path) == "factual-recall"
     agents.set_agent_generator_profile("alice", None, data_dir=tmp_path)
     assert agents.get_agent_generator_profile("alice", data_dir=tmp_path) is None
+    # field must be absent from the stored record, not just None-valued
+    assert "generator_profile_id" not in registry.get_agent("alice")
 
 
 def test_set_agent_generator_profile_unknown_agent_raises(tmp_path):

tests/test_generator_profile_cli.py

@@ -16,3 +16,18 @@ def test_cli_list_and_set(tmp_path, capsys):
 def test_cli_set_rejects_unknown(tmp_path):
     rc = cli._generator_profile_set("nope", agent=None, data_dir=tmp_path)
     assert rc != 0
+
+
+def test_cli_set_per_agent(tmp_path):
+    from taosmd import agents
+    agents.AgentRegistry(tmp_path).register_agent("alice")
+    rc = cli._generator_profile_set("factual-recall", agent="alice", data_dir=tmp_path)
+    assert rc == 0
+    assert agents.get_agent_generator_profile("alice", data_dir=tmp_path) == "factual-recall"
+
+
+def test_cli_set_unknown_agent_returns_nonzero(tmp_path, capsys):
+    rc = cli._generator_profile_set("balanced", agent="ghost", data_dir=tmp_path)
+    assert rc != 0
+    err = capsys.readouterr().err
+    assert "ghost" in err

tests/test_generator_resolution.py

@@ -48,3 +48,18 @@ def test_per_agent_beats_global(at_12gb, tmp_path):
     agents.AgentRegistry(tmp_path).register_agent("bob")
     agents.set_agent_generator_profile("bob", "factual-recall", data_dir=tmp_path)
     assert gp.resolve_generator("bob", data_dir=tmp_path) == "ollama:gemma4:12b"
+
+
+def test_resolve_memory_model_uses_per_agent_profile(at_12gb, tmp_path):
+    from taosmd import config, agents
+    # global profile is balanced (qwen3.5:9b at gpu-12gb)
+    config.set_generator_profile("balanced", data_dir=tmp_path)
+    agents.AgentRegistry(tmp_path).register_agent("carol")
+    # per-agent profile is factual-recall (gemma4:12b at gpu-12gb)
+    agents.set_agent_generator_profile("carol", "factual-recall", data_dir=tmp_path)
+    result = config.resolve_memory_model(agent="carol", data_dir=tmp_path)
+    # must differ from global default (qwen3.5:9b) and match factual-recall
+    assert result == "ollama:gemma4:12b"
+    global_result = config.resolve_memory_model(data_dir=tmp_path)
+    assert global_result == "ollama:qwen3.5:9b"
+    assert result != global_result