Skip to content

test(profiles): negative-path coverage for generator-profile setters - #179

Merged
jaylfc merged 1 commit into
masterfrom
test/generator-profile-negative-paths
Jun 30, 2026
Merged

test(profiles): negative-path coverage for generator-profile setters#179
jaylfc merged 1 commit into
masterfrom
test/generator-profile-negative-paths

Conversation

@jaylfc

@jaylfc jaylfc commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Closes deferred test minors flagged in the #177/#178 reviews. Pure test additions, no production change:

  • config.set_generator_profile rejects blank/whitespace/non-string ids (ValueError) and persists nothing.
  • agents.set/get_agent_generator_profile raise AgentNotFoundError for an unregistered agent.
  • agents.set_agent_generator_profile clears on empty string (not just None).

Targeted run: 6 passed.

@jaylfc
jaylfc merged commit 3055ede into master Jun 30, 2026
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f581eae9-1027-427d-a0a3-80cede7799a4

📥 Commits

Reviewing files that changed from the base of the PR and between 2c2b77c and a920413.

📒 Files selected for processing (2)
  • tests/test_generator_profile_agent.py
  • tests/test_generator_profile_config.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/generator-profile-negative-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot

kilo-code-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Note: PR was already merged at time of review (head a920413). No actionable issues found in changed test code.

Files Reviewed (2 files)
  • tests/test_generator_profile_agent.py
  • tests/test_generator_profile_config.py

Reviewed by minimax-m3 · Input: 35.2K · Output: 2K · Cached: 217.7K

jaylfc added a commit that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant