Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add uninsert method #521

Merged
merged 3 commits into from
Nov 21, 2024
Merged

add uninsert method #521

merged 3 commits into from
Nov 21, 2024

Conversation

jnsbck
Copy link
Contributor

@jnsbck jnsbck commented Nov 20, 2024 •
edited
Loading

This PR adds an uninsert method.

I find the name a bit wonky tbh. Was also wondering if we should add a disconnect method to connect.py.

todos:

  • add tests

@jnsbck jnsbck linked an issue Nov 20, 2024 that may be closed by this pull request
an .uninsert() method for channels #506
Closed
@michaeldeistler
Copy link
Contributor

Regarding the name: I am not a huge fan of uninsert either, but not sure about other options. Maybe we could go with delete_channel() (similar to delete_recordings())?

@jnsbck
Copy link
Contributor Author

jnsbck commented Nov 21, 2024

I like delete_channel much better! @michaeldeistler if you could have a quick look, that'd be great :)

michaeldeistler
michaeldeistler approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

jaxley/modules/base.py Show resolved Hide resolved
@jnsbck jnsbck merged commit 8ce2428 into main Nov 21, 2024
1 check passed
@jnsbck jnsbck deleted the 506-an-uninsert-method-for-channels branch November 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

an .uninsert() method for channels
2 participants
@jnsbck @michaeldeistler