-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests with fixtures #499
Conversation
PR is currently WIP. Might also try to reduce test runtime. |
a5303ed
to
1e0f515
Compare
PR introduces simpler test primitives, adds The following I am unsure about:
EDIT: These are the currently used stimuli.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
…s not seem to speed up tests significantly
c1e7fc6
to
3f77697
Compare
This PR adds test fixtures for the modules that have to be re initialized again and again during testing. This should reduce overhead and make tests more readable. The fixtures are such that if i.e.
Branch(nseg=4)
was already used by a prev test, the fixture returns a copy of it, if not it is build from scratch and cached. Higher order modules, i.e.Cell([Branch(nseg=4)], [-1,0,0])
that are build later can also make use of the pre-build submodules via the fixtures.This compliments #479 and contributes towards #449.