Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tutorials on indexing and parameter sharing #464

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Conversation

michaeldeistler
Copy link
Contributor

@michaeldeistler michaeldeistler commented Oct 24, 2024

This PR adds two advanced tutorials (setting synaptic parameter values and synaptic parameter sharing). As part of this, it modifies the outline of the website and splits tutorials into Tutorials and Advanced tutorials.

To make synaptic parameter sharing possible, this PR also contributes the .copy_node_property_to_edges() and adds tests for it:

net.copy_node_property_to_edges("global_cell_index")

df = net.edges
df = df.query("pre_global_cell_index in [3, 4]")
net.select(edges=df.index).set("Ionotropic_gS", 0.2)

Copy link
Contributor

@jnsbck jnsbck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely love this! Especially the use of pandas query, which I did not foresee being such a clean and powerful combination together with select.

I left a few comments. Good to go once addressed.

jaxley/modules/base.py Outdated Show resolved Hide resolved
docs/tutorials/09_advanced_indexing.ipynb Outdated Show resolved Hide resolved
docs/tutorials/09_advanced_indexing.ipynb Outdated Show resolved Hide resolved
docs/tutorials/09_advanced_indexing.ipynb Outdated Show resolved Hide resolved
docs/tutorials/09_advanced_indexing.ipynb Outdated Show resolved Hide resolved
docs/tutorials/10_advanced_parameter_sharing.ipynb Outdated Show resolved Hide resolved
docs/tutorials/10_advanced_parameter_sharing.ipynb Outdated Show resolved Hide resolved
@michaeldeistler michaeldeistler merged commit ad6ce01 into main Nov 13, 2024
1 check passed
@michaeldeistler michaeldeistler deleted the newtutorials branch November 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants