fix units of compute_current #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
force-pushed
the
units
branch
from
1e2fe7b to
55e915d
Compare
michaeldeistler
force-pushed
the
units
branch
from
5ff35ca to
6739599
Compare
This was referenced Oct 23, 2024
michaeldeistler
force-pushed
the
units
branch
from
4c8b799 to
daaa3b7
Compare
huangziwei
approved these changes
Oct 24, 2024
jaxley/modules/base.py
Outdated
| voltage_terms = voltage_terms.at[indices].add(voltage_term * 1000.0) | ||
| constant_terms = constant_terms.at[indices].add(-constant_term * 1000.0) | ||
| else: | ||
| # If `current_is_in_mA_per_cm2=False` then the current is assumed as |
There was a problem hiding this comment.
I'd remove the backward compatibility here, simply because giving people options will make them lazy to adopt the new convention. it's also confusing if both conventions floating around, and it'll be difficult to debug once things go wrong.
michaeldeistler
added a commit
that referenced
this pull request
Nov 13, 2024
* fix units of compute_current * Enforce new unit convention * Add raise and warn for old channel models * add option to use `current_is_in_mA_per_cm2=False` * Add test * Remove warning * fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274
This is a tricky PR as it will impact users which ported channels themselves. I hope that this is not many people yet, so now is the time to still do it.