Checked if the recodings are empty

[deezer257]

I inserted a check if the recording DataFrame is empty, if so I raised an value error. Nevertheless, I use a WSL and at some point the tests got stuck, at about 80% of completion, and the WSL lost connection.

Closes #365

[michaeldeistler]

Thanks! Please add a quick test to tests/ that checks whether this indeed raises an error. E.g.

comp = jx.Compartment()
with pytest.raises(ValueError):
    v = jx.integrate(comp, delta_t=0.025, t_max=10.0)

[deezer257]

Test is implemented.

[michaeldeistler]

Thanks! But the test is not a Python file. Please add the test to tests/test_record_and_stimulate.py and create a def test_empty_recordings() there.

[michaeldeistler]

Tests are not passing. You probably did not run black tests?

[deezer257]

I only ran the specific test since all tests would take an hour to run. I will do it tomorrow, sorry!

[michaeldeistler]

Thanks again! black passes now, but the test you wrote now exists twice :D (You can always check changed files to see what you are trying to merge).

Could you delete the tests/test_empty_recording file?

[michaeldeistler]

Looks great now, thanks a ton! I will merge once tests have passed.