Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Euler and Cranck Nicolson solvers #413

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Conversation

michaeldeistler
Copy link
Contributor

@michaeldeistler michaeldeistler commented Aug 30, 2024

This PR fixes forward Euler solvers and also implements a Cranck Nicolson solver.

Forward Euler raises for branched cells (or networks thereof).

@michaeldeistler michaeldeistler requested a review from jnsbck August 30, 2024 14:54
@jnsbck
Copy link
Contributor

jnsbck commented Aug 30, 2024

Cool! Will have a look on Monday!

@michaeldeistler
Copy link
Contributor Author

Great, thanks!

Copy link
Contributor

@jnsbck jnsbck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no major concerns and only smaller comments. Good to go from my side after they have been addressed.

jaxley/modules/base.py Outdated Show resolved Hide resolved
jaxley/solver_voltage.py Outdated Show resolved Hide resolved
tests/test_solver.py Show resolved Hide resolved
jaxley/modules/base.py Outdated Show resolved Hide resolved
@michaeldeistler michaeldeistler merged commit 2501c86 into main Sep 2, 2024
1 check passed
@michaeldeistler michaeldeistler deleted the forwardeuler branch September 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants