[NVIDIA] Throw an error for unsupported bias shape when cudnn backend is used in nn.dot_product_attention
#23740
+127
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaixih
force-pushed
the
dbias_bwd_batcher
branch
from
b87a668
to
406ba4e
Compare
kaixih
force-pushed
the
dbias_bwd_batcher
branch
from
406ba4e
to
b7e26ba
Compare
kaixih
changed the title
nn.dot_product_attention
|
I’ve implemented a new change that defines custom VJP rules and batching rules to validate the bias shape in both bprop and vmap usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue reported in here.
cc. @sbodenstein