Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation for jnp.atleast_*d #23654

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Better documentation for jnp.atleast_*d #23654

merged 1 commit into from
Sep 16, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Sep 16, 2024 •
edited
Loading

@jakevdp jakevdp self-assigned this Sep 16, 2024
@jakevdp jakevdp requested a review from dfm September 16, 2024 13:28
dfm
dfm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@dfm dfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

(The behavior of atleast_3d has always been baffling to me - it's fun to finally read a docstring :D)

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Sep 16, 2024
@jakevdp
Copy link
Collaborator Author

jakevdp commented Sep 16, 2024

(The behavior of atleast_3d has always been baffling to me - it's fun to finally read a docstring :D)

Yeah agreed...

@copybara-service copybara-service bot merged commit 8a867c1 into jax-ml:main Sep 16, 2024
16 checks passed
@jakevdp jakevdp deleted the atleast-nd-docs branch September 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfm dfm dfm approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakevdp @dfm @kokoro-team