DOC: Improved documentation for numpy.frombuffer #23556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
requested changes
Sep 11, 2024
selamw1
force-pushed
the
docstring_frombuffer
branch
from
364cf60
to
7aa931d
Compare
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
reviewed
Sep 12, 2024
jax/_src/numpy/lax_numpy.py
Outdated
| def frombuffer(buffer: bytes | Any, dtype: DTypeLike = float, | ||
| count: int = -1, offset: int = 0) -> Array: | ||
| """Convert a buffer into a 1-D JAX array. |
There was a problem hiding this comment.
This should fix the test failure:
Suggested change
| """Convert a buffer into a 1-D JAX array. | |
| r"""Convert a buffer into a 1-D JAX array. |
selamw1
force-pushed
the
docstring_frombuffer
branch
from
7aa931d
to
b2ab9d8
Compare
|
Doc test failure fixed. |
|
The current error is due to jaxlib 0.4.32 being yanked. If you rebase on the updated main branch, then tests should pass. Thanks! |
selamw1
force-pushed
the
docstring_frombuffer
branch
from
b2ab9d8
to
8db394e
Compare
|
rebased from the updated main branch. |
jakevdp
requested changes
Sep 14, 2024
description_changed_examp_added doc_byte_fixed discription_modified
selamw1
force-pushed
the
docstring_frombuffer
branch
from
8db394e
to
7dde9b2
Compare
|
@jakevdp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21461