-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create JAX Advanced Tutorials (section, move/create docs) #23165
Create JAX Advanced Tutorials (section, move/create docs) #23165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several of these sections are duplicative of existing docs (e.g. docs/external-callbacks.md
and docs/notebooks/external_callbacks.md
.
More work is necessary to de-duplicate these, update indices, and re-direct old URLs to the new locations. See #21064 for an example of how we did this in the past
Also, rather than creating new files, we should move the old files out of docs/_tutorials
to their new location, in order to preserve change history.
76ac690
to
726c8a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors are due to the change noted below; also it looks like there are two remaining uses of the understanding-jaxprs
reference that need to be updated, one in glossary.rst
and one in jit-compilation.md
.
29456b2
to
0fabd73
Compare
0fabd73
to
c708b7c
Compare
01e315b
to
95f7335
Compare
95f7335
to
65ce1bf
Compare
@jakevdp PTAL |
038d7ad
to
a533635
Compare
c9c3094
to
9465d42
Compare
dc26b37
to
0cf040c
Compare
As we discussed, the structure of the left-nav dropdown is still not exactly how we'd like it, but we can land and iterate. Thanks for working on this! |
@jakevdp