Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix mypy errors #22920

Merged
merged 1 commit into from
Aug 7, 2024
Merged

CI: fix mypy errors #22920

merged 1 commit into from
Aug 7, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Aug 7, 2024 •
edited
Loading

Fix errors introduced by #22830

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Aug 7, 2024
@jakevdp jakevdp self-assigned this Aug 7, 2024
@jakevdp jakevdp changed the title CI: fix lint check CI: fix mypy errors Aug 7, 2024
yashk2810
yashk2810 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@yashk2810 yashk2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hit this on my CL too

@copybara-service copybara-service bot merged commit 7efca04 into jax-ml:main Aug 7, 2024
14 checks passed
@jakevdp jakevdp deleted the fix-lint branch August 7, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakevdp @yashk2810 @kokoro-team