Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been wanting to change this for a while, because "wraps" is really a misnomer here: wraps implies that the decorated function somehow calls out to the wrapped function, but that is not the case for JAX implementations of NumPy functions. I think
implements
is more accurate for this case.Also remove the leading underscore: it's misleading because we expect this function to be used outside the module that defines it (it's still defined in
jax._src
, however, so it's not a public API).