Bugfixes: Unknown props, prop-types, inline-styles, and ESLint #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Added yarn.lock file and note about contributing
| onLoadFunction, | ||
| resizeInterval, | ||
| ...other | ||
| } = this.props; |
There was a problem hiding this comment.
The recommended way to _.omit props before passing the rest down.
src/blur.jsx
Outdated
| position: 'absolute', | ||
| top: 0, | ||
| left: 0, | ||
| } : {}; |
There was a problem hiding this comment.
Added the enableStyles because inlining them immediately lead to a breaking change on my end (since I wasn't using them).
I suppose this is substantial enough to increase the major version.
|
Totally amazing job @mherodev! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After putting together some relatively simple bugfixes, I ran into linting issues in VS Code that were best resolved by upgrading ESLint. And then upgrading dependencies. And reworking the eslint config.
So this PR is now far from a "logical chunk". I'm sorry.
Long story short, I replaced the existing eslint implementation with the airbnb configuration. I also went through and updated
Blur.jsxto use the latest conventions and libraries (e.g.prop-types).I also resolved issues #7 and #15 (which was my original intent, whoops).
Edit: And I included Prettier to passively enforce coding style.
Hopefully that's all well and good! Love the library.