Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downstream support for get_data implementation #15

Conversation

kecnry
Copy link

@kecnry kecnry commented May 24, 2023

This PR implements mask_subset in the private _get_data method which applies any generic subset as a mask. spectral_subset is then a special case of this mask_subset where type-checks are done to ensure its spectral. Downstream apps (such as lcviz - see this PR for required changes there if this is adopted) can then write their own get_data method which does its own type-checks, if necessary, and passes any type of subset to mask_subset (as long as it doesn't also pass spectral_subset).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant