Bump astro to ^6.1.8 (unpin — upstream fix shipped)#13
Merged
Conversation
astro@6.1.8 (2026-04-18) ships both fixes for the plugin-chunk-imports regression that forced the 6.1.2 pin in PR #12: - withastro/astro#16282 — corrects the offset math that was splicing `?` into dynamic import() specifiers (the root cause of our Netlify failure). - withastro/astro#16367 — adds a cleanChunkName() sanitizer as defense in depth against `!`, `~`, `{`, `}` leaking into chunk filenames. Verified locally with `DEPLOY_ID=local-test pnpm build`: - Build succeeds; no `_astro/*.!~{…}~.js` placeholder filenames emitted. - `grep import\("\./ dist/_astro/VideoModal*.js` shows well-formed rewrites like `import("./plyr.<hash>.js?dpl=local-test")`. @astrojs/netlify returns to ^7.0.7 — compatible again now that astro has the `verifyOptions` export the adapter needs. Docs updated: known-issues.md flips from "waiting for fix" to historical reference, TODO unpin item checked off. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for javelina-works ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Enable CI checks, update security vulnerabilities, add lock to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unpin
astroand@astrojs/netlifynow that the upstream fix forwithastro/astro#16209 has
shipped.
astro@6.1.8(2026-04-18) includes both the root-cause fix#16282 (offset math for
dynamic-import specifier rewriting) and the defense-in-depth fix
#16367
(
cleanChunkNamesanitizer).Changes
astro6.1.2^6.1.8@astrojs/netlify7.0.6^7.0.7Plus:
docs/astro/known-issues.mdflips from "waiting for fix" to ahistorical reference, and the TODO.md unpin item is checked off.
🚫 Do not merge yet
Holding this PR until the CI workflow is re-enabled and includes a
DEPLOY_ID=ci pnpm buildstep. That step is the only automatedprotection against this class of regression recurring — without it, the
next drift into a broken astro patch release will be caught only by a
Netlify deploy failure again.
Merge order will be:
DEPLOY_ID=ci pnpm buildstep.(emergency 6.1.2 pin) →
main.staging→main, with CI green.Test plan
Already run locally:
pnpm install && pnpm buildon pinned versions → success.DEPLOY_ID=local-test pnpm build→ success; no!~{…}~chunkfilenames emitted.
grep import\("\./ dist/_astro/VideoModal*.js→ specifiers looklike
import("./plyr.<hash>.js?dpl=local-test")(well-formed —?dpl=…is inside the string literal, not spliced mid-specifieras it was under 6.1.7).
To run before merging:
VideoModalin the deploy preview (opens, plays,autoplay where configured).
🤖 Generated with Claude Code