Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private and protected properties and methods #451

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

ish-kafel
Copy link
Contributor

@ish-kafel ish-kafel commented Aug 14, 2019

目标章节:1-js/09-classes/04-private-protected-properties-methods

当前上游最新 commit:7fd3eb1

所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md 6d1fa5d 翻译为中文

Translate into Chinese
@CLAassistant
Copy link

CLAassistant commented Aug 14, 2019

CLA assistant check
All committers have signed the CLA.

@lycheeEng
Copy link
Collaborator

校对认领

@lycheeEng
Copy link
Collaborator

lycheeEng commented Aug 14, 2019

看了一下英文版,原作者对这部分内容有改动,要不你先与英文版同步修改一下?
英文版:https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/09-classes/04-private-protected-properties-methods/article.md

同步英文版
@ish-kafel
Copy link
Contributor Author

已和英文版同步

Copy link
Collaborator

@lycheeEng lycheeEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完成,感谢翻译

@ish-kafel
Copy link
Contributor Author

感谢校正,已修正翻译

@lycheeEng
Copy link
Collaborator

再次感谢~

@lycheeEng lycheeEng merged commit a19b51a into javascript-tutorial:master Aug 16, 2019
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #324 🎉 🎉 🎉

@lycheeEng lycheeEng added DONE and removed needs +1 labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants