Add method java.lang.String.getBytes(byte[], int, byte) #136
Conversation
| if (coder() == coder) { | ||
| System.arraycopy(value, 0, dst, dstBegin << coder, value.length); | ||
| } else { | ||
| StringLatin1.inflate(value, 0, dst, dstBegin, value.length); |
There was a problem hiding this comment.
This seems to cover two cases:
- Both encodings (source, target) are the same.
- The target encoding is UTF-8 but the source is Latin-1.
However, what about the case that the source encoding is UTF-8 and the target is Latin-1?
There was a problem hiding this comment.
If you are sure that the other case never occurs, please write an assertion that checks this (with an assertion message explaining this).
There was a problem hiding this comment.
The official doc comment include this:
Invoker guarantees: dst is in UTF16 (inflate itself for asb), if two coders are different, and dst is big enough (range check)
The method is also package-private. Anyway, I could add an assertion that checks whether the target is in UTF16.
|
Yes, please add an assertion check and put your comment as a comment in the code. |
Add method java.lang.String.getBytes(byte[], int, byte) to MJI model class for java.lang.String This also fixes: [junit] java.lang.NoSuchMethodError: java.lang.String.getBytes([BIB)V [junit] at java.lang.AbstractStringBuilder.putStringAt(AbstractStringBuilder.java:1641)
|
Please see the made changes. |
Add method java.lang.String.getBytes(byte[], int, byte) to MJI model class for java.lang.String
This also fixes #134: