Add java.lang.Class#getModule to MJI model class #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method java.lang.Class#getModule to MJI model class for
java.lang.Class
This also fixes:
[junit] java.lang.NoSuchMethodError:
java.lang.Class.getModule()Ljava/lang/Module;
| @@ -60,6 +60,9 @@ | |||
|
|
|||
| private String name; | |||
|
|
|||
| // set by VM | |||
There was a problem hiding this comment.
Could you please clarify this comment?
Does JPF's VM or the host VM try to set this field?
There is currently no accessor method, and as the field is now, it seems jpf-core would not use it at this point. However, without an accessor, the host VM could not set this field (except by reflection, which can access private data).
There was a problem hiding this comment.
Based on the JDK source there is no accessor setModule. But through remote debugging, I was able to confirm that the java.lang.Class#getModule method in our Class model returns the correct (non-null) module for that class. So it should be set by the host VM, possibly through reflection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method java.lang.Class#getModule to MJI model class for java.lang.Class
This also fixes #124 :