Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure SID related memory is properly released once no longer required #602

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

lgoldstein
Copy link
Contributor

The code was not releasing properly SID memory allocated by the ConvertSidXXX methods.

@twall
Copy link
Contributor

twall commented Mar 1, 2016

Good catch, LGTM.

lgoldstein added a commit that referenced this pull request Mar 3, 2016
Make sure SID related memory is properly released once no longer required
@lgoldstein lgoldstein merged commit bbc2291 into java-native-access:master Mar 3, 2016
@lgoldstein lgoldstein deleted the sid-free branch March 3, 2016 06:17
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
Motivation:

The asseertation of the params was not correct and so could fail
sometimes

Modifications:

Fix assert

Result:

Testsuite passes all the time again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants