Fix return type of Native#loadLibrary to match unconstrained generic … #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoldstein
force-pushed
the
load-library-fix
branch
from
20dda2b
to
93ca701
Compare
|
BTW, this still does not explain why the Travis-CI succeeded (otherwise you would not have merged it) but the merged build fails since the Travis-CI runs the same tests. I strongly suspect that the merged build does not start from a clean slate or does not run ant clean before running. |
|
Please let me know if I should go ahead and merge the pull request - FYI, I will be out-of-reach for the next 2 weeks (starting from Fri.) and the longer we wait with this, the harder it will be to merge and see if it fixes the issue. Also, please make sure that the Jenkins build that seems to fail always runs ant clean before attempting to build anything. |
|
ok to merge. |
lgoldstein
pushed a commit
that referenced
this pull request
Dec 17, 2015
Fix return type of Native#loadLibrary to match unconstrained generic …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 - this time I feel more confident in the result since I have run the ant clean and then ant including full build of the native code + running the jUnit tests (all passed). Like I said, if it fails again for the same reason, then let's roll back the changes.