-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved function call performance #353
Conversation
@Boereck You have to rebase with master. Do this:
Then, review the diff here. It should look clean. Another, possibly simpler way of doing this is to abandon this branch.
|
Thanks a lot for your help! I just started my vacation and am away until the 12th of August. I will take care of this as soon as I am back. Currently I am just equipped with my phone. |
So the diff here looks good now. You could have a second look now. Thanks! |
Please re-merge from master, which should fix the CI issue, then this can be merged. |
3aa6ea4
to
e003913
Compare
e003913
to
239e98e
Compare
I moved the commit on top of the latest master now. |
Please resolve the conflict so I can merge this. Sorry for the long delay. |
8338947
to
49359e6
Compare
Function#invoke. This saves costs for map and reflection lookups.
49359e6
to
b6d56e8
Compare
Improved function call performance
Motivation: A new netty release is ou Modifications: Update to latest release Result: Depend on 4.1.70.Final
Hi, another change for method call performance. Some unnecessary time was spent in Function#invoke(Class returnType, Object[] inArgs, Map options). The method looked up the method object and the parameter types, although this information is already available, when invoking the method from Library$Handler#invoke(Object proxy, Method method, Object[] inArgs). So I refactored both classes a bit so that no unnecessary work is done. In my tests function calls are now measurably faster and produce fewer objects (->less garbage).