Add fix for issue #135 in Advapi32Util (reading empty values) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty values) With this fix it is possible to read values from registry of the following types even when the size of the value is 0: REG_SZ REG_EXPAND_SZ REG_MULTI_SZ REG_NONE REG_BINARY (fixed by earlier committer) Advapi32UtilTest updated with unit test triggering the bug.
|
Thanks, merging. Could you please update CHANGES as well? |
dblock
added a commit
that referenced
this pull request
Oct 8, 2012
Add fix for issue #135 in Advapi32Util (reading empty values)
|
The CHANGES file has been updated in my topic-branch. Do you want a new pull request? |
|
Yes, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix it is possible to read values from registry of the following
types even when the size of the value is 0:
REG_SZ
REG_EXPAND_SZ
REG_MULTI_SZ
REG_NONE
REG_BINARY (fixed by earlier committer)
Advapi32UtilTest updated with unit test triggering the bug.