NPE in finalizer of ProxyObject

[fitermay]

https://github.com/java-native-access/jna/blob/ea9de70cb73ca0794120666e8ed9794d88ea5c81/contrib/platform/src/com/sun/jna/platform/win32/COM/util/ProxyObject.java line 138

Throws NPE in the finalizer if (Dispatch) this.rawDispatch).getPointer() is null. It tries to call 'equals' on a null reference.

[matthiasblaesing]

Yes it explodes there - why do you think creating a ProxyObject on a NULL dispatch object is a valid case? How is the code reached? My fix would be to raise the NPE from the constructor and be done with that.

[fitermay]

It blows up because the object is already disposed. Notice if dispose is called twice it blows up

[matthiasblaesing]

Ok - on first reading I did not realize, that Pointer.NULL is a fancy way to say null. I added a fix (switch from equals comparison to identity comparison) and added a unittest, that reproduces the problem without the fix.

Thanks for reporting this problem