fix: Float functions should return the proper number of decimals #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the float functions to return the proper number of decimals, based off of the maxDecimals argument. Prior to this fix, a random value was generated between 0 and
maxDecimals
and that was used as the decimal portion. This meant that values generated with maxDecimals=2, the decimal portion of all generated values would be either.0
,.1
or.2
, instead of there being 2 digits in the decimal portion. With the fix, values generated with maxDecimals=2 will have a decimal portion anywhere between.00
and.99
, inclusively.Missing tests were also added for
Float
,Float32
andFloat64
Are you trying to fix an existing issue?
#177
Go Version
Go Tests