36708 integrations manager plugin

.backportrc.json

@@ -1,5 +1,5 @@
 {
   "upstream": "elastic/kibana",
-  "branches": [{ "name": "7.x", "checked": true }, "7.1", "7.0", "6.8", "6.7", "6.6", "6.5", "6.4", "6.3", "6.2", "6.1", "6.0", "5.6"],
+  "branches": [{ "name": "7.x", "checked": true }, "7.2", "7.1", "7.0", "6.8", "6.7", "6.6", "6.5", "6.4", "6.3", "6.2", "6.1", "6.0", "5.6"],
   "labels": ["backport"]
 }

.ci/jobs.yml

@@ -21,6 +21,9 @@ JOB:
   - x-pack-ciGroup5
   - x-pack-ciGroup6
   - x-pack-ciGroup7
+  - x-pack-ciGroup8
+  - x-pack-ciGroup9
+  - x-pack-ciGroup10
 
 # `~` is yaml for `null`
 exclude: ~

.eslintignore

@@ -31,9 +31,11 @@ bower_components
 /x-pack/plugins/**/__tests__/fixtures/**
 /packages/kbn-interpreter/src/common/lib/grammar.js
 /x-pack/plugins/canvas/canvas_plugin
+/x-pack/plugins/canvas/storybook
 /x-pack/plugins/canvas/canvas_plugin_src/lib/flot-charts
 /x-pack/plugins/infra/common/graphql/types.ts
 /x-pack/plugins/infra/public/graphql/types.ts
 /x-pack/plugins/infra/server/graphql/types.ts
+**/graphql/types.ts
 **/*.js.snap
 !/.eslintrc.js

.eslintrc.js

@@ -184,7 +184,13 @@ module.exports = {
         // instructs import/no-extraneous-dependencies to treat modules
         // in plugins/ or ui/ namespace as "core modules" so they don't
         // trigger failures for not being listed in package.json
-        'import/core-modules': ['plugins', 'legacy/ui', 'uiExports'],
+        'import/core-modules': [
+          'plugins',
+          'legacy/ui',
+          'uiExports',
+          // TODO: Remove once https://github.com/benmosher/eslint-plugin-import/issues/1374 is fixed
+          'querystring',
+        ],
 
         'import/resolver': {
           '@kbn/eslint-import-resolver-kibana': {
@@ -400,10 +406,181 @@ module.exports = {
      * SIEM overrides
      */
     {
-      files: ['x-pack/plugins/siem/**/*.ts'],
+      // front end typescript and javascript files only
+      files: ['x-pack/plugins/siem/public/**/*.{js,ts,tsx}'],
+      rules: {
+        'import/no-nodejs-modules': 'error',
+        'no-restricted-imports': [
+          'error',
+          {
+            // prevents UI code from importing server side code and then webpack including it when doing builds
+            patterns: ['**/server/*'],
+          },
+        ],
+      },
+    },
+    {
+      // typescript only for front and back end
+      files: ['x-pack/plugins/siem/**/*.{ts,tsx}'],
       rules: {
+        // This will be turned on after bug fixes are complete
+        // '@typescript-eslint/explicit-member-accessibility': 'warn',
+        '@typescript-eslint/no-this-alias': 'error',
         '@typescript-eslint/no-explicit-any': 'error',
-        'import/order': 'error',
+        '@typescript-eslint/no-useless-constructor': 'error',
+        // This will be turned on after bug fixes are complete
+        // '@typescript-eslint/no-object-literal-type-assertion': 'warn',
+        '@typescript-eslint/unified-signatures': 'error',
+
+        // eventually we want this to be a warn and then an error since this is a recommended linter rule
+        // for now, keeping it commented out to avoid too much IDE noise until the other linter issues
+        // are fixed in the next release or two
+        // '@typescript-eslint/explicit-function-return-type': 'warn',
+
+        // these rules cannot be turned on and tested at the moment until this issue is resolved:
+        // https://github.com/prettier/prettier-eslint/issues/201
+        // '@typescript-eslint/await-thenable': 'error',
+        // '@typescript-eslint/no-non-null-assertion': 'error'
+        // '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+        // '@typescript-eslint/no-unused-vars': 'error',
+        // '@typescript-eslint/prefer-includes': 'error',
+        // '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+        // '@typescript-eslint/promise-function-async': 'error',
+        // '@typescript-eslint/prefer-regexp-exec': 'error',
+        // '@typescript-eslint/promise-function-async': 'error',
+        // '@typescript-eslint/require-array-sort-compare': 'error',
+        // '@typescript-eslint/restrict-plus-operands': 'error',
+        // '@typescript-eslint/unbound-method': 'error',
+      },
+    },
+    {
+      // typescript and javascript for front and back end
+      files: ['x-pack/plugins/siem/**/*.{js,ts,tsx}'],
+      plugins: ['eslint-plugin-node', 'react'],
+      rules: {
+        'accessor-pairs': 'error',
+        'array-callback-return': 'error',
+        'no-array-constructor': 'error',
+        // This will be turned on after bug fixes are mostly completed
+        // 'arrow-body-style': ['warn', 'as-needed'],
+        complexity: 'warn',
+        // This will be turned on after bug fixes are mostly completed
+        // 'consistent-return': 'warn',
+        // This will be turned on after bug fixes are mostly completed
+        // 'func-style': ['warn', 'expression'],
+        // These will be turned on after bug fixes are mostly completed and we can
+        // run a fix-lint
+        /*
+        'import/order': [
+          'warn',
+          {
+            groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
+            'newlines-between': 'always',
+          },
+        ],
+        */
+        'node/no-deprecated-api': 'error',
+        'no-bitwise': 'error',
+        'no-continue': 'error',
+        'no-dupe-keys': 'error',
+        'no-duplicate-case': 'error',
+        // This will be turned on after bug fixes are mostly completed
+        // 'no-duplicate-imports': 'warn',
+        'no-empty-character-class': 'error',
+        'no-empty-pattern': 'error',
+        'no-ex-assign': 'error',
+        'no-extend-native': 'error',
+        'no-extra-bind': 'error',
+        'no-extra-boolean-cast': 'error',
+        'no-extra-label': 'error',
+        'no-floating-decimal': 'error',
+        'no-func-assign': 'error',
+        'no-implicit-globals': 'error',
+        'no-implied-eval': 'error',
+        'no-invalid-regexp': 'error',
+        'no-inner-declarations': 'error',
+        'no-lone-blocks': 'error',
+        'no-multi-assign': 'error',
+        'no-misleading-character-class': 'error',
+        'no-new-symbol': 'error',
+        'no-obj-calls': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-param-reassign': 'warn',
+        'no-process-exit': 'error',
+        'no-prototype-builtins': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-return-await': 'warn',
+        'no-self-compare': 'error',
+        'no-shadow-restricted-names': 'error',
+        'no-sparse-arrays': 'error',
+        'no-this-before-super': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-undef': 'warn',
+        'no-unreachable': 'error',
+        'no-unsafe-finally': 'error',
+        'no-useless-call': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-useless-catch': 'warn',
+        'no-useless-concat': 'error',
+        'no-useless-computed-key': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-useless-escape': 'warn',
+        'no-useless-rename': 'error',
+        // This will be turned on after bug fixes are mostly complete
+        // 'no-useless-return': 'warn',
+        // This will be turned on after bug fixers are mostly complete
+        // 'no-void': 'warn',
+        'one-var-declaration-per-line': 'error',
+        'prefer-object-spread': 'error',
+        'prefer-promise-reject-errors': 'error',
+        'prefer-rest-params': 'error',
+        'prefer-spread': 'error',
+        // This style will be turned on after most bugs are fixed
+        // 'prefer-template': 'warn',
+        // This style will be turned on after most bugs are fixed
+        // quotes: ['warn', 'single', { avoidEscape: true }],
+        'react/boolean-prop-naming': 'error',
+        'react/button-has-type': 'error',
+        'react/forbid-dom-props': 'error',
+        'react/no-access-state-in-setstate': 'error',
+        // This style will be turned on after most bugs are fixed
+        // 'react/no-children-prop': 'warn',
+        'react/no-danger-with-children': 'error',
+        'react/no-deprecated': 'error',
+        'react/no-did-mount-set-state': 'error',
+        // Re-enable once we have better options per this issue:
+        // https://github.com/airbnb/javascript/issues/1875
+        // 'react/no-did-update-set-state': 'error',
+        'react/no-direct-mutation-state': 'error',
+        'react/no-find-dom-node': 'error',
+        'react/no-redundant-should-component-update': 'error',
+        'react/no-render-return-value': 'error',
+        'react/no-typos': 'error',
+        'react/no-string-refs': 'error',
+        'react/no-this-in-sfc': 'error',
+        'react/no-unescaped-entities': 'error',
+        'react/no-unsafe': 'error',
+        'react/no-unused-prop-types': 'error',
+        'react/no-unused-state': 'error',
+        // will introduced after the other warns are fixed
+        // 'react/sort-comp': 'error',
+        'react/void-dom-elements-no-children': 'error',
+        'react/jsx-boolean-value': ['error', 'warn'],
+        // will introduced after the other warns are fixed
+        // 'react/jsx-no-bind': 'error',
+        'react/jsx-no-comment-textnodes': 'error',
+        'react/jsx-no-literals': 'error',
+        'react/jsx-no-target-blank': 'error',
+        'react/jsx-fragments': 'error',
+        'react/jsx-sort-default-props': 'error',
+        // might be introduced after the other warns are fixed
+        // 'react/jsx-sort-props': 'error',
+        'react/jsx-tag-spacing': 'error',
+        'require-atomic-updates': 'error',
+        'rest-spread-spacing': ['error', 'never'],
+        'symbol-description': 'error',
+        'template-curly-spacing': 'error',
+        'vars-on-top': 'error',
       },
     },
 
@@ -529,5 +706,16 @@ module.exports = {
         jquery: true,
       },
     },
+
+    /**
+     * TSVB overrides
+     */
+    {
+      files: ['src/legacy/core_plugins/metrics/**/*.js'],
+      excludedFiles: 'src/legacy/core_plugins/metrics/index.js',
+      rules: {
+        'import/no-default-export': 'error',
+      },
+    },
   ],
 };

.github/CODEOWNERS

@@ -23,12 +23,15 @@
 /x-pack/plugins/ml/  @elastic/ml-ui
 
 # Operations
+/renovate.json5 @elastic/kibana-operations
 /src/dev/ @elastic/kibana-operations
 /src/setup_node_env/ @elastic/kibana-operations
 /src/optimize/ @elastic/kibana-operations
 
 # Platform
 /src/core/  @elastic/kibana-platform
+/src/legacy/server/saved_objects/  @elastic/kibana-platform
+/src/legacy/ui/public/saved_objects  @elastic/kibana-platform
 
 # Security
 /x-pack/plugins/security/  @elastic/kibana-security

.gitignore

@@ -5,7 +5,7 @@
 .DS_Store
 .node_binaries
 node_modules
-!/src/dev/npm/__tests__/fixtures/fixture1/node_modules
+!/src/dev/npm/integration_tests/__fixtures__/fixture1/node_modules
 !/src/dev/notice/__fixtures__/node_modules
 trash
 /optimize
@@ -31,7 +31,7 @@ webpackstats.json
 !/config/kibana.yml
 coverage
 selenium
-.babelcache.json
+.babel_register_cache.json
 .webpack.babelcache
 *.swp
 *.swo

.i18nrc.json

@@ -24,13 +24,15 @@
     "kbnESQuery": "packages/kbn-es-query",
     "xpack.apm": "x-pack/plugins/apm",
     "xpack.beatsManagement": "x-pack/plugins/beats_management",
+    "xpack.canvas": "x-pack/plugins/canvas",
     "xpack.crossClusterReplication": "x-pack/plugins/cross_cluster_replication",
     "xpack.dashboardMode": "x-pack/plugins/dashboard_mode",
     "xpack.graph": "x-pack/plugins/graph",
     "xpack.grokDebugger": "x-pack/plugins/grokdebugger",
     "xpack.idxMgmt": "x-pack/plugins/index_management",
     "xpack.indexLifecycleMgmt": "x-pack/plugins/index_lifecycle_management",
     "xpack.infra": "x-pack/plugins/infra",
+    "xpack.integrationsManager": "x-pack/plugins/integrations_manager",
     "xpack.kueryAutocomplete": "x-pack/plugins/kuery_autocomplete",
     "xpack.licenseMgmt": "x-pack/plugins/license_management",
     "xpack.maps": "x-pack/plugins/maps",
@@ -51,10 +53,9 @@
     "xpack.uptime": "x-pack/plugins/uptime",
     "xpack.watcher": "x-pack/plugins/watcher"
   },
-  "exclude": [
-    "src/legacy/ui/ui_render/ui_render_mixin.js"
-  ],
+  "exclude": ["src/legacy/ui/ui_render/ui_render_mixin.js"],
   "translations": [
-    "x-pack/plugins/translations/translations/zh-CN.json"
+    "x-pack/plugins/translations/translations/zh-CN.json",
+    "x-pack/plugins/translations/translations/ja-JP.json"
   ]
 }