Baseline boilerplate for asset_inventory plugin#12
Closed
jasonrhodes wants to merge 5 commits into
Closed
Conversation
ruflin
approved these changes
Dec 5, 2022
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Did not test this one but I assume we can just get in as foundation for the other PR's?
Owner
Author
Yep exactly |
This includes the server and public folders with a simple page template in place.
.keyword was introduced in the queries when the mappings were improperly configured. First attempt to change the mappings failed because it had subobjects: false in the top level of the dynamic assets mapping template. I moved subobjects: false into the properties -> asset block instead, so that ECS fields can be nested as usual, but asset fields will only work as dotted.
jasonrhodes
force-pushed
the
asset-inventory-baseline
branch
from
e0ce75c to
fc419cb
Compare
Owner
Author
|
Renaming long-running branch to just asset-inventory and closing this initial baseline PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This creates a new plugin in Kibana called "asset_inventory", including the server and public folders with a simple page template in place.
This is related to the Asset Inventory and Topology POC/demo work.